Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript.md #1151

Closed
wants to merge 1 commit into from
Closed

Update typescript.md #1151

wants to merge 1 commit into from

Conversation

github0013
Copy link

webpacker 3.2.0 has drastic changes in the rules directory.

https://github.com/rails/webpacker/tree/v3.1.1/package/rules
https://github.com/rails/webpacker/tree/v3.2.0/package/rules

If you don't add ts-loader in the environment.js, you will end up with this error.

ERROR in ./app/javascript/packs/hello_react.tsx
Module parse failed: Unexpected token (10:11)
You may need an appropriate loader to handle this file type.
| class Hello extends React.Component {
|   render() {
|     return <div>hello world</div>;
|   }
| }
 @ multi (webpack)-dev-server/client?http://localhost:3035 ./app/javascript/packs/hello_react.tsx

@corymcdonald
Copy link
Contributor

Hey there! I actually added an installer for typescript in this PR - #1145

I think this might fix this issue

@github0013 github0013 deleted the typescript_doc branch January 11, 2018 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@github0013 @corymcdonald @gauravtiwari